[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

[Michał Górny via Phabricator via lldb-commits]

mgorny updated this revision to Diff 334725.
mgorny added a comment.

Add some tests.

@labath, I'd use some help now. When the stop reason includes wrong PID, the GDB exchange seems to enter a dead loop:

  b-remote.async>  <   5> send packet: $c#63
  b-remote.async>  <  25> read packet: $S02thread:p404.10210;#cc
  intern-state     <  16> send packet: $qfThreadInfo#bb
  intern-state     <  26> read packet: $mp400.10200,p400.10204#e7
  intern-state     <  16> send packet: $qsThreadInfo#c8
  intern-state     <   5> read packet: $l#6c

I think this is because most of the code doesn't really care about `SetThreadStopInfo()`'s return value, and I'm not really convinced that's the best way of reporting an error. Could you suggest how to handle 'wrong PID' error here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99603/new/

https://reviews.llvm.org/D99603

Files:
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99603.334725.patch
Type: text/x-patch
Size: 12025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210401/253cbf25/attachment.bin>