[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 1 09:15:05 PDT 2021
mgorny updated this revision to Diff 334725.
mgorny added a comment.
Add some tests.
@labath, I'd use some help now. When the stop reason includes wrong PID, the GDB exchange seems to enter a dead loop:
b-remote.async> < 5> send packet: $c#63
b-remote.async> < 25> read packet: $S02thread:p404.10210;#cc
intern-state < 16> send packet: $qfThreadInfo#bb
intern-state < 26> read packet: $mp400.10200,p400.10204#e7
intern-state < 16> send packet: $qsThreadInfo#c8
intern-state < 5> read packet: $l#6c
I think this is because most of the code doesn't really care about `SetThreadStopInfo()`'s return value, and I'm not really convinced that's the best way of reporting an error. Could you suggest how to handle 'wrong PID' error here?
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12025 bytes
Desc: not available
More information about the lldb-commits