[Lldb-commits] [lldb] b468f0e - [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 1 02:18:13 PDT 2021


Author: Muhammad Omair Javaid
Date: 2021-04-01T14:16:54+05:00
New Revision: b468f0e165ed67c5b1046b295b65e446afee62aa

URL: https://github.com/llvm/llvm-project/commit/b468f0e165ed67c5b1046b295b65e446afee62aa
DIFF: https://github.com/llvm/llvm-project/commit/b468f0e165ed67c5b1046b295b65e446afee62aa.diff

LOG: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

This fixes flakiness in TestVSCode_launch.test_progress_events
vscode.progress_events some times failed to populate in time for
follow up iterations.

Adding a minor delay before the the for the loop fixes the issue.

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D99497

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
index aceed56fe2491..dc4549cd3251c 100644
--- a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
+++ b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
@@ -454,7 +454,6 @@ def test_terminate_commands(self):
 
     @skipIfWindows
     @skipIfRemote
-    @skipIf(oslist=["linux"])
     def test_progress_events(self):
         '''
             Tests the progress events to ensure we are receiving them.
@@ -486,6 +485,8 @@ def test_progress_events(self):
         # Iterate over all progress events and save all start and end IDs, and
         # remember any shared libraries that got symbol table parsing progress
         # events.
+        # Sleep for 2 seconds to make sure progress_events gets populated
+        time.sleep(2)
         for progress_event in self.vscode.progress_events:
             event_type = progress_event['event']
             if event_type == 'progressStart':


        


More information about the lldb-commits mailing list