[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Mar 31 21:46:44 PDT 2021
JDevlieghere added a comment.
LGTM with a little nit. Please `clang-format` the patch before landing.
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h:89-100
+ // There are two routines in the ObjC runtime that tagged pointer clients
+ // can call to get the value from their tagged pointer, one that retrieves
+ // it as an unsigned value and one a signed value. These two
+ // GetTaggedPointerInfo methods mirror those two ObjC runtime calls.
virtual bool GetTaggedPointerInfo(uint64_t *info_bits = nullptr,
uint64_t *value_bits = nullptr,
uint64_t *payload = nullptr) = 0;
Please make this a Doxygen comment and include both methods in a group.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits