[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 30 09:53:56 PDT 2021


shafik added inline comments.


================
Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:214
+      if (FileSystem::Instance().Exists(module_spec.GetFileSpec())) {
+        module_sp.reset(new Module(module_spec));
+      }
----------------
We can use `make_shared` here instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99571/new/

https://reviews.llvm.org/D99571



More information about the lldb-commits mailing list