[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

Tue Mar 30 09:49:46 PDT 2021

mgorny added a comment.

In D98482#2658991 <https://reviews.llvm.org/D98482#2658991>, @stella.stamenova wrote:

> Looks like this broke the Windows lldb buildbot:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/5173

Thanks for pinging me. It seems that all Hg tests fail on Windows, so just added xfail to these 3 as well.

================
Comment at: lldb/include/lldb/Utility/StringExtractorGDBRemote.h:197
+  static constexpr lldb::pid_t AllProcesses = UINT64_MAX;
+  static constexpr lldb::tid_t AllThreads = UINT64_MAX;
+
----------------
labath wrote:
> These also need a definition in the .cpp file (debug builds fail without that).
I've reproduced that and fixed it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98482/new/

https://reviews.llvm.org/D98482