[Lldb-commits] [lldb] ea08d4b - [lldb] Remove ScriptInterpreterLuaTest.Plugin unittest

[Pavel Labath via lldb-commits]

Author: Pavel Labath
Date: 2021-03-30T08:48:56+02:00
New Revision: ea08d4ba37362506ebd30957a9473467df6f00b9

URL: https://github.com/llvm/llvm-project/commit/ea08d4ba37362506ebd30957a9473467df6f00b9
DIFF: https://github.com/llvm/llvm-project/commit/ea08d4ba37362506ebd30957a9473467df6f00b9.diff

LOG: [lldb] Remove ScriptInterpreterLuaTest.Plugin unittest

This test is not useful as the functions it's testing are just returning
a constant. It also fails in unoptimized builds as it's comparing
character strings by address.

Added: 
    

Modified: 
    lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp b/lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp
index 3b7fbebdd98d..e4aebfb650c0 100644
--- a/lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp
+++ b/lldb/unittests/ScriptInterpreter/Lua/ScriptInterpreterTests.cpp
@@ -43,12 +43,6 @@ class ScriptInterpreterTest : public ::testing::Test {
 };
 } // namespace
 
-TEST_F(ScriptInterpreterTest, Plugin) {
-  EXPECT_EQ(ScriptInterpreterLua::GetPluginNameStatic(), "script-lua");
-  EXPECT_EQ(ScriptInterpreterLua::GetPluginDescriptionStatic(),
-            "Lua script interpreter");
-}
-
 TEST_F(ScriptInterpreterTest, ExecuteOneLine) {
   DebuggerSP debugger_sp = Debugger::CreateInstance();
   ASSERT_TRUE(debugger_sp);