[Lldb-commits] [lldb] 3c95bdf - [lldb] Don't search for system specific strings in assert.test

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 29 01:46:56 PDT 2021


Author: Raphael Isemann
Date: 2021-03-29T10:46:14+02:00
New Revision: 3c95bdf9fa35f0fe2143ea859b624c8f09513adb

URL: https://github.com/llvm/llvm-project/commit/3c95bdf9fa35f0fe2143ea859b624c8f09513adb
DIFF: https://github.com/llvm/llvm-project/commit/3c95bdf9fa35f0fe2143ea859b624c8f09513adb.diff

LOG: [lldb] Don't search for system specific strings in assert.test

Commit 6bc1e69de270db8d7191200f54158e4192f997ba changed the search string
to also check for the generated strings that surround the plain assert:

    Assertion `false && "lldb-test assert"' failed
                                         ^^^^^^^^^

This causes the test to fail on setups where the generated assert message
looks different. E.g., on macOS the generated message looks like this:

    Assertion failed: (false && "lldb_assert failed"), function lldb_assert

This reverts the old behaviour of just checking for the actual string we
have inside LLDB.

Added: 
    

Modified: 
    lldb/test/Shell/Error/assert.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/Error/assert.test b/lldb/test/Shell/Error/assert.test
index 2585e64f3952..3678b45c0ad7 100644
--- a/lldb/test/Shell/Error/assert.test
+++ b/lldb/test/Shell/Error/assert.test
@@ -1,4 +1,4 @@
 # REQUIRES: asserts
 # RUN: not --crash lldb-test assert > %t.error 2>&1
 # RUN: cat %t.error | FileCheck %s
-# CHECK: "{{lldb_assert failed|lldb-test assert}}"' failed.
+# CHECK: {{lldb_assert failed|lldb-test assert}}


        


More information about the lldb-commits mailing list