[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

Thu Mar 25 05:53:45 PDT 2021

teemperor edited reviewers, added: jingham; removed: LLVM.
teemperor added a comment.

Thanks for the patch!

A few general notes:

- You probably want to upload the diffs with more context (`git diff -U9999` or something like that) to get rid of the "Context not available" in the source changes part. That's sadly how Phabricator works. If you use arcanist to upload patches then I believe it does that automatically for you.
- Please don't add unrelated projects such as "LLDB test suite on simulator" (those are like tags that are used to group reviews that are all related to a specific task/goal). "LLDB" is the right project for general LLDB patches ("LLVM" for patches that target the general LLVM part in `llvm/`).

Regarding the patch itself: From what I understand what this test (maybe unintentionally) tests it that when we do `step-in` we apply the `target.process.thread.step-avoid-regexp` setting (which will skip all `std::*` functions when doing a step-in from what I know). So It's not clear how to me how LLDB ends up stepping into the `std::string` constructor (even if `ccac` is using a custom standard library). Can you post some more details about the test failure you're setting (e.g., where you end up with the source breakpoint and where the step-in actually takes you).

I think this is in any case something for Jim to review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99331/new/

https://reviews.llvm.org/D99331