[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

[Alexey Vasilyev via Phabricator via lldb-commits]

vasilyev created this revision.
vasilyev added a reviewer: LLVM.
vasilyev added projects: LLVM, LLDB test suite on simulator.
vasilyev requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The tests expect the debugger steps into the function, not the string constructor. But that depends on the compiler. Thus, with "ssas" the tests are failing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99331

Files:
  lldb/test/API/functionalities/inline-stepping/calling.cpp


Index: lldb/test/API/functionalities/inline-stepping/calling.cpp
===================================================================
--- lldb/test/API/functionalities/inline-stepping/calling.cpp
+++ lldb/test/API/functionalities/inline-stepping/calling.cpp
@@ -129,8 +129,12 @@
     
     function_to_call (); // Make sure debug info for this function gets generated.
     
-    max_value(123, 456);                                // Call max_value template
-    max_value(std::string("abc"), std::string("0022")); // Call max_value specialized
+    max_value(123, 456); // Call max_value template
+
+    std::string s1 = "aba";
+    std::string s2 = "0022";
+
+    max_value(s1, s2);  // Call max_value specialized
 
     return 0;            // About to return from main.
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99331.333259.patch
Type: text/x-patch
Size: 777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210325/fc984b3e/attachment.bin>