[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:533
   static PlatformSP CreateInstance(bool force, const ArchSpec *arch) {
+    if (arch && arch->IsValid() && !arch->TripleEnvironmentWasSpecified())
+      return nullptr; // Avoid very slow xcrun query for non-simulator archs.
----------------
We should extract this into a little helper function to avoid the code (and comment) duplication.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:534
+    if (arch && arch->IsValid() && !arch->TripleEnvironmentWasSpecified())
+      return nullptr; // Avoid very slow xcrun query for non-simulator archs.
     llvm::StringRef sdk;
----------------
Is it equivalent to return nullptr here to passing an empty string as the `sdk`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98272/new/

https://reviews.llvm.org/D98272