[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

[Neal via Phabricator via lldb-commits]

nealsid marked 2 inline comments as done.
nealsid added a comment.

In D98153#2610953 <https://reviews.llvm.org/D98153#2610953>, @teemperor wrote:

> Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr checks that affect a normal LLDB session (not sure if we can ever have no SymbolContext) or is this just for the unit test?
>
> Anyway, I have some small inline comments but otherwise this looks pretty good to me.

Missed this earlier - I think you're right, because the formatting code is used for thread/frame lists & information, so there will be a SymbolContext.  But one my planned upcoming changes is to use it in the LLDB prompt, where a target might not be available.  And it's also more consistent with formatting code for other Entry types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98153/new/

https://reviews.llvm.org/D98153