[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

[Neal via Phabricator via lldb-commits]

nealsid marked 3 inline comments as done.
nealsid added inline comments.


================
Comment at: lldb/include/lldb/Core/FormatEntity.h:144
+            num_children(num_children), children(children),
+            keep_separator(keep_separator) {}
     };
----------------
teemperor wrote:
> I believe you could make this far less verbose with delegating constructors and using C++11 default member initializers.
Makes sense - I used default member initializers but once I did that, delegating constructors seemed to add more code back in :) So I just stuck with the member initializers.  


================
Comment at: lldb/source/Core/FormatEntity.cpp:1759
+      return false;
+    }
     const char *name = nullptr;
----------------
teemperor wrote:
> One-line if's don't have `{}` around the body according to LLVM code style (I know this is wrong in a lot of LLDB code, but newer code should follow that style). Just commenting this once but the same thing is happening above/below this change too.
Done, here and in other spots I noticed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98153/new/

https://reviews.llvm.org/D98153