[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

Thu Mar 4 17:29:19 PST 2021

mhorne added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:807
+        if lldb.SBPlatform.GetHostPlatform().GetOSMajorVersion() < 14:
+            return False, "Watchpoint support on arm64 requires FreeBSD 14.0"
     return True, "watchpoint support available"
----------------
It seems like this should become 13.0.

================
Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h:28
+#  define LLDB_HAS_FREEBSD_WATCHPOINT 1
+#elif __FreeBSD_version >= 1300139 && __FreeBSD_version < 1400000
+#  define LLDB_HAS_FREEBSD_WATCHPOINT 1
----------------
This is technically correct, but I don't think it's important to make provisions for versions 1400000 to 1400004. The reason is that these represent development versions in a < 2 month time period. Anyone affected by this would simply be asked to update their kernel to a more recent snapshot.

`__FreeBSD_version >= 1300139` should be enough.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96548/new/

https://reviews.llvm.org/D96548