[Lldb-commits] [PATCH] D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h:12
 
+#include <bitset>
+
----------------
We generally include system headers after project headers.


================
Comment at: lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h:68
   OptionDefinition m_option_definition[4];
+  std::bitset<4> m_required_options;
 };
----------------
I don't mind the bitset but we have a `Flags` utility that seems like a good fit for this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97910/new/

https://reviews.llvm.org/D97910