[Lldb-commits] [PATCH] D97910: [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 3 21:43:46 PST 2021


mib created this revision.
mib added reviewers: JDevlieghere, teemperor.
mib added a project: LLDB.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.

When using `OptionGroupPythonClassWithDict` options in an `OptionGroup`
with other `Options`, it can happen that the combinaison of some options
of each group makes the command invalid.

To solve that issue, this patch adds a bitmask argument to the
`OptionGroupPythonClassWithDict` constuctor that is used to mark each
option as required (or not).

If the `required_options` bitmask isn't passed to the constructor, the
class will keep its default behaviour, making the `--script-class` and
`--python-function` options required.

rdar://65508855

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97910

Files:
  lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h
  lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97910.328017.patch
Type: text/x-patch
Size: 4813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210304/e85ba136/attachment.bin>


More information about the lldb-commits mailing list