[Lldb-commits] [PATCH] D97486: [lldb/Core] Change large function threshold variable into a setting.

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 2 01:33:32 PST 2021


mib added a comment.

In D97486#2596523 <https://reviews.llvm.org/D97486#2596523>, @labath wrote:

> As the author of this logic, I want to note that the original limit I chose was very arbitrary, and 32k (or any other small-ish number would work equally well). The main objective was to disable accidental multi-megabyte disassemblies (which can happen when the object file has no symbol information).
>
> I'm not actually opposed to the, just wanting to make sure you're not adding it on my account.

I made that change after being requested to increase the limit. I thought turning it into a setting gives the user more flexibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97486/new/

https://reviews.llvm.org/D97486



More information about the lldb-commits mailing list