[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

Tue Mar 2 00:04:27 PST 2021

labath added a comment.

In D95712#2566203 <https://reviews.llvm.org/D95712#2566203>, @JDevlieghere wrote:

> In D95712#2563091 <https://reviews.llvm.org/D95712#2563091>, @labath wrote:
>
>> Unfortunately I don't have the bandwidth to review this, though I feel that this should have a wider discussion, given that its destined to become a pretty big chunk of our public immutable api surface.
>
> When @mib and I discussed this offline, the idea was to start with an interface that matches the C++ class and iterate on it as we gain more experience through different use cases. Initially those uses cases consist of core file debugging with a scripted process and using it to write tests for things that have historically hard to test (@jasonmolenda has a better idea of what these are). Long term the scriptable process plugin would be like the OS plugins on steroids and would probably superseed them. I expect the XNU people (who are currently the main users of the OS plugins) to have valuable input on the interface as well. Until then the interface shouldn't be considered stable.
>
> @mib Can you please add a disclaimed to the base class saying that the interface is subject to change?

Making the api flexible alleviates a lot of my concerns. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95712/new/

https://reviews.llvm.org/D95712