[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

Mon Mar 1 23:52:50 PST 2021

labath added a comment.

In D96778#2595162 <https://reviews.llvm.org/D96778#2595162>, @jankratochvil wrote:

> In D96778#2595110 <https://reviews.llvm.org/D96778#2595110>, @stella.stamenova wrote:
>
>> What is the actual test requirement?
>
> It requires x86_64 (it is incompatible with x86_32) and hopefully it is OS-agnostic (after fixing the %clang_host).

This assembly is definitely not os-agnostic. I tried writing one once -- after writing a bunch of macros to abstract the differences (different labels, different ways to do section cross-references, ...) I eventually gave up. I think it should run on elf-based systems (linux + BSD variants). I believe the only way to express that now is to write `UNSUPPORTED: system-darwin, system-windows`, though it may be interesting to add an `system-elf` feature or something.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778