[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

Neal via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 1 19:02:20 PST 2021


nealsid added a comment.

In D50299#2596141 <https://reviews.llvm.org/D50299#2596141>, @JDevlieghere wrote:

> In D50299#2596008 <https://reviews.llvm.org/D50299#2596008>, @nealsid wrote:
>
>> Removed comment on #include line and organized the #includes to match coding guidelines better (I wasn't sure about whether the project uses blank lines in between #includes from different subproject like lldb/clang/llvm so I didn't make the change more broadly)
>
> Looks good. Let me know if you don't have commit access and need me to land this for you.

I do not have commit access, so if you could land it, that would be great.  Appreciate the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50299/new/

https://reviews.llvm.org/D50299



More information about the lldb-commits mailing list