[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D96778#2594405 <https://reviews.llvm.org/D96778#2594405>, @jankratochvil wrote:

> @stella.stamenova It failed on a Windows box:
> https://lab.llvm.org/buildbot/#/builders/83/builds/4202
>
>   $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" "--target=specify-a-target-or-use-a-_host-substitution" "-o" "C:\buildbot\lldb-x64-windows-ninja\build\tools\lldb\test\SymbolFile\DWARF\Output\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s.tmp" "--target=x86_64-pc-linux" "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s" "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF/Inputs/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu2.s"
>   # command stderr:
>   clang: error: unable to execute command: program not executable
>
> Do you think the following change would fix it?
>
>   -// RUN: %clang -o %t --target=x86_64-pc-linux %s \
>   +// RUN: %clang_host -o %t %s \

Yes, I would expect it to.

> The test was also executed on lldb-aarch64-ubuntu -- https://lab.llvm.org/buildbot/#/changes/13868
> But we have REQUIRES: x86, shouldn't it exclude ARM?

My understanding it that `REQUIRES` indicates a target that should be included in the build. This particular buildbot includes the X86 target, so the test ran. What is the actual test requirement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778