[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

[Shoaib Meenai via Phabricator via lldb-commits]

smeenai added inline comments.


================
Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147
+  add_custom_command(TARGET liblldb POST_BUILD
+    COMMAND ${CMAKE_COMMAND} -E create_symlink
+            Versions/Current/XPCServices
+            ${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
+    COMMENT "LLDB.framework: create symlink XPCServices"
+  )
----------------
vsk wrote:
> smeenai wrote:
> > This bit appears to have been introduced by this revision, without any equivalent existing before. This is causing issues for us when we build an LLDB framework in LLVM 12, because `Versions/Current/XPCServices` doesn't exist, so the created symlink is dangling. Is there some other target which should be creating that directory? (This is the only instance of `XPCServices` I see in LLDB's build.)
> Thanks for catching this. I'm curious how you spotted this. It looks like we do have a target that sets up this directory, but that it's not upstream. It should be safe to remove this; we can reapply the change downstream if that happens.
There's a part of our build/distribution infrastructure which checksums the built directory, and it failed for LLVM 12 because it tried to follow the dangling symlink. I put up D97701 to remove this; thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85770/new/

https://reviews.llvm.org/D85770