[Lldb-commits] [lldb] 776be16 - Fix virtual-dtor warning a different way, since a virtual dtor is not required for this use case.

[David Blaikie via lldb-commits]

Author: David Blaikie
Date: 2021-03-01T09:25:26-08:00
New Revision: 776be16ba0532dbb3d66cc104d15a7f13a154e3f

URL: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f
DIFF: https://github.com/llvm/llvm-project/commit/776be16ba0532dbb3d66cc104d15a7f13a154e3f.diff

LOG: Fix virtual-dtor warning a different way, since a virtual dtor is not required for this use case.

Added: 
    

Modified: 
    lldb/unittests/Interpreter/TestOptionValue.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Interpreter/TestOptionValue.cpp b/lldb/unittests/Interpreter/TestOptionValue.cpp
index b31422e0259b..7f383424368b 100644
--- a/lldb/unittests/Interpreter/TestOptionValue.cpp
+++ b/lldb/unittests/Interpreter/TestOptionValue.cpp
@@ -14,12 +14,13 @@ using namespace lldb_private;
 
 class Callback {
 public:
-  virtual ~Callback() = default;
   virtual void Invoke() const {}
   void operator()() const { Invoke(); }
+protected:
+  ~Callback() = default;
 };
 
-class MockCallback : public Callback {
+class MockCallback final : public Callback {
 public:
   MOCK_CONST_METHOD0(Invoke, void());
 };