[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

This looks good overall except for one comment inline.



================
Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43
+
+ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1,
+                                                  lldb::addr_t addr2) const {
----------------
I am a little apprehensive about this AddressDiff function. AArch64 virtual address is either 48 bits or 52 bits. MTE start from 56th bit and I believe bits (48 - 55) will be either set zero (for user address) and set to one for kernel addresses. 
I am not sure if there is an interface available for us to know if VA is 48 or 52 bits. What do you think how should we manage this here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97281/new/

https://reviews.llvm.org/D97281