[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime
Shoaib Meenai via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 22 14:27:16 PST 2021
smeenai added a comment.
My understanding of the issue is that, with the runtimes build, the `cxx` target will get created after we process LLDB's build files. The `TARGET cxx` check here will therefore fail, but the `cxx` target will end up existing later, and CMake is perfectly fine adding a dependency to a target that gets created later, so the failing check is spurious. The `libcxx IN_LIST LLVM_ENABLE_RUNTIMES` is basically a proxy for "the `cxx` target doesn't exist right now but will exist later". Could you add an explanation of the issue to the summary or the code comment?
(Note that if you change a commit message locally, `arc diff` won't update the summary of this review by default ... you'll need `arc diff --verbatim` to make it update the summary.)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits