[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

Richard Howell via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 22 14:08:24 PST 2021


rmaz created this revision.
Herald added a subscriber: mgorny.
rmaz requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

When enabling LLDB tests with `LLVM_ENABLE_RUNTIMES=libcxx` CMake will fail with:

  LLDB test suite requires libc++, but it is currently disabled. 

This change adds support for tests to use the libcxx runtime too.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97227

Files:
  lldb/test/CMakeLists.txt


Index: lldb/test/CMakeLists.txt
===================================================================
--- lldb/test/CMakeLists.txt
+++ lldb/test/CMakeLists.txt
@@ -106,7 +106,7 @@
     else()
       # We require libcxx for the test suite, so if we aren't building it,
       # try to provide a helpful error about how to resolve the situation.
-      if(NOT TARGET cxx)
+      if(NOT TARGET cxx AND NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
         if(LLVM_ENABLE_PROJECTS STREQUAL "")
           # If `LLVM_ENABLE_PROJECTS` is not being used (implying that we are
           # using the old layout), suggest checking it out.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97227.325564.patch
Type: text/x-patch
Size: 624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210222/d746473e/attachment.bin>


More information about the lldb-commits mailing list