[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 18 15:25:54 PST 2021


jankratochvil added a comment.

In D96778#2572816 <https://reviews.llvm.org/D96778#2572816>, @dblaikie wrote:

> rolls this into one file with two CUs - bit easier to deal with.

Then one could not use the `.file` directives and one would need to code also `.debug_line` by hand.

> You could remove a bunch of extraneous DWARF too - since it's hardcoded DWARF, the subprogram/inlined subroutine/etc could be removed from CU1, leaving only the abstract subprogram and variable, both to be referenced from CU2.

True, I have removed it now.

> Could you provide the source code for this - I wouldn't mind trying it out and seeing what might be different/why DWZ doesn't understand this.

dwz will merge it without -flto but not with -flto: http://people.redhat.com/jkratoch/inlinevar.d.tar.xz
Personally I am not interested in DWZ, I am implementing it only as a compatibility with existing file format, IMNSHO DWZ should be dropped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778



More information about the lldb-commits mailing list