[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 17 14:33:38 PST 2021


shafik marked an inline comment as done.
shafik added inline comments.


================
Comment at: clang/lib/AST/TypePrinter.cpp:1308
+    } else if ((isa<RecordDecl>(D) && cast<RecordDecl>(D)->isAnonymousStructOrUnion()) ||
+        isa<EnumDecl>(D)) {
       OS << "anonymous";
----------------
aaron.ballman wrote:
> I think `EnumDecl` should probably be `unnamed` rather than `anonymous` because there's no term of art for an anonymous enumeration (there's only anonymous structures and anonymous unions). WDYT?
I thought I saw that wording but when I looked back I realize you are correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96807/new/

https://reviews.llvm.org/D96807



More information about the lldb-commits mailing list