[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/include/lldb/Target/LanguageRuntime.h:187
+  static lldb::UnwindPlanSP
+  GetAsyncedFrameUnwindPlan(lldb_private::Thread &thread,
+                            lldb_private::RegisterContext *regctx);
----------------
jingham wrote:
> JDevlieghere wrote:
> > `s/Asynced/Async/` maybe?
> Maybe "Pending"?  From the standpoint of the API, it doesn't really matter why there are some not-currently executing stacks, just that they are not currently executing.  Pending describes the state, not the why, so might be more appropriate.
Thanks for the comments all.  Yeah the wording Asynced is a little weird, but I was trying to get across the idea that a function is executing normally on the stack, then it is descheduled (or the function it calls is executed on another thread) and it has been async'ified from its previous running state, and will later revivify.  But it's probably more trouble than it's worth and I should just use Async here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96839/new/

https://reviews.llvm.org/D96839