[Lldb-commits] [PATCH] D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.

"Asynced" sounds funny to me, but I don't have suggestions other than "Async".

Looks good to me.



================
Comment at: lldb/source/Target/RegisterContextUnwind.cpp:558
+      m_full_unwind_plan_sp = async_plan_sp;
+      if (active_row.get() && log) {
+        StreamString active_row_strm;
----------------
Looks like active_row will always be valid here, as the code is currently constructed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96839/new/

https://reviews.llvm.org/D96839