[Lldb-commits] [lldb] 9f38001 - [lldb] [Process/FreeBSD] Ensure that errors are always handled

Michał Górny via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 16 13:22:19 PST 2021


Author: Michał Górny
Date: 2021-02-16T22:21:37+01:00
New Revision: 9f38001bf07252bc29671cf49b42351f34172dea

URL: https://github.com/llvm/llvm-project/commit/9f38001bf07252bc29671cf49b42351f34172dea
DIFF: https://github.com/llvm/llvm-project/commit/9f38001bf07252bc29671cf49b42351f34172dea.diff

LOG: [lldb] [Process/FreeBSD] Ensure that errors are always handled

Ensure that the llvm::Error instances are always considered handled
by replacing LLDB_LOG with LLDB_LOG_ERROR.

Differential Revision: https://reviews.llvm.org/D96558

Added: 
    

Modified: 
    lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp
index 10fafe675221..44797cd555c9 100644
--- a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp
@@ -213,8 +213,9 @@ void NativeProcessFreeBSD::MonitorSIGTRAP(lldb::pid_t pid) {
       llvm::Error error = t.CopyWatchpointsFrom(
           static_cast<NativeThreadFreeBSD &>(*GetCurrentThread()));
       if (error) {
-        LLDB_LOG(log, "failed to copy watchpoints to new thread {0}: {1}",
-                 info.pl_lwpid, llvm::toString(std::move(error)));
+        LLDB_LOG_ERROR(log, std::move(error),
+                       "failed to copy watchpoints to new thread {1}: {0}",
+                       info.pl_lwpid);
         SetState(StateType::eStateInvalid);
         return;
       }


        


More information about the lldb-commits mailing list