[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Core/Value.cpp:574
     switch (m_value_type) {
-    case eValueTypeScalar: // raw scalar value
+    case ValueType::Invalid:
+    case ValueType::Scalar: // raw scalar value
----------------
aprantl wrote:
> shafik wrote:
> > In the invalid case does `m_value` have some initial value i.e. it is not uninitialized. 
> I don't understand what you are asking here?
The other cases initialize `m_value` or call `Clear` on it and `m_value` is return at the end and I was asking is it is properly initialized.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96537/new/

https://reviews.llvm.org/D96537