[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

> (Btw, if you intend to cherry-pick this into swift/main for some reason then please let me know as this probably will cause a bunch of conflicts with the temporarily reverted patch from Pavel).

I don't //need// to cherry-pick it, so I won't for now.



================
Comment at: lldb/source/Core/Value.cpp:574
     switch (m_value_type) {
-    case eValueTypeScalar: // raw scalar value
+    case ValueType::Invalid:
+    case ValueType::Scalar: // raw scalar value
----------------
shafik wrote:
> In the invalid case does `m_value` have some initial value i.e. it is not uninitialized. 
I don't understand what you are asking here?


================
Comment at: lldb/source/Core/ValueObjectConstResult.cpp:148
   m_value.GetScalar().GetData(m_data, addr_byte_size);
-  // m_value.SetValueType(Value::eValueTypeHostAddress);
+  // m_value.SetValueType(Value::ValueType::HostAddress);
   switch (address_type) {
----------------
shafik wrote:
> dead code?
Yes, but I'm not going to touch this in this commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96537/new/

https://reviews.llvm.org/D96537