[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 1 16:02:36 PST 2021


kastiglione added inline comments.


================
Comment at: lldb/test/API/python_api/frame/TestFrames.py:97
                     sp_value, "We should have a valid Stack Pointer.")
-                self.assertTrue(int(sp_value.GetValue(), 0) == frame.GetSP(
+                self.assertEqual(int(sp_value.GetValue(), 0), frame.GetSP(
                 ), "SP gotten as a value should equal frame's GetSP")
----------------
JDevlieghere wrote:
> Very odd/confusing formatting. 
I noticed this too in the diff, I'll fix it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95813/new/

https://reviews.llvm.org/D95813



More information about the lldb-commits mailing list