[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Cool, I was under the impression @teemperor had already done something similar, but I must be misremembering.



================
Comment at: lldb/test/API/python_api/frame/TestFrames.py:97
                     sp_value, "We should have a valid Stack Pointer.")
-                self.assertTrue(int(sp_value.GetValue(), 0) == frame.GetSP(
+                self.assertEqual(int(sp_value.GetValue(), 0), frame.GetSP(
                 ), "SP gotten as a value should equal frame's GetSP")
----------------
Very odd/confusing formatting. 


================
Comment at: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py:53
 
-        self.assertTrue(len(yours) == len(mine))
+        self.assertEqual(len(yours), len(mine))
         for i in range(len(yours)):
----------------
😁


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95813/new/

https://reviews.llvm.org/D95813