[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added a comment.

Thanks for the review! Fixed the `virtual` and rebased, will test now and push if it still builds ;-).



================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.h:88
+protected:
+  virtual llvm::Expected<llvm::ArrayRef<uint8_t>>
+  GetSoftwareBreakpointTrapOpcode(size_t size_hint) override;
----------------
labath wrote:
> I believe we don't put `virtual` on overridden methods..
Indeed we don't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95696/new/

https://reviews.llvm.org/D95696