[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

[Tom Stellard via Phabricator via lldb-commits]

tstellar added a comment.

In D89156#2530703 <https://reviews.llvm.org/D89156#2530703>, @Abpostelnicu wrote:

> In D89156#2530701 <https://reviews.llvm.org/D89156#2530701>, @JosephTremoulet wrote:
>
>> Oh, I see.  I made this change in the master branch and then ported it to the release/11.x branch.  It changed the signature of a virtual method, which had a couple more overrides in the release/11.x branch, and when I ported the change I didn't realize those other overrides existed.  So now the release/11.x builds that include those overrides (btw, what build flags are needed to include those?) are broken.  I'm not sure what the options are now that 11.0.1 has been released and 11.1.0 is at rc2 -- @tstellar, thoughts?
>
> I have a fix for this ready, I can push it to 11.0.1.

Can you file a bug for this or re-open the merge request bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156