[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Fri Jan 29 07:14:12 PST 2021

Abpostelnicu added a comment.

In D89156#2530656 <https://reviews.llvm.org/D89156#2530656>, @JosephTremoulet wrote:

> In D89156#2530353 <https://reviews.llvm.org/D89156#2530353>, @Abpostelnicu wrote:
>
>> Shouldn't this also update PlatformiOSSimulator.h?
>
> There is no PlatformOSSimulator.h file (or I can't find it).  There is a type `PlatformiOSSumulator`, but it doesn't have its own `GetSharedModule` method.  Its `CreateInstance` method returns a `PlatformAppleSimulator`[1], and this change does update `PlatformAppleSimulator`.  So unless I'm misunderstanding your point, I don't think any changes specific to PlatformiOSSimulator are needed
>
> 1 - https://github.com/llvm/llvm-project/blob/82847436e9258a12503dcfadb5dc373cb42fea43/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp#L538

Well, there is https://github.com/llvm/llvm-project/tree/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX
And if you look here https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h#L57 you will see why the build will crash.
Also this applies for the AppleTV implementation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89156/new/

https://reviews.llvm.org/D89156