[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9
+
+#if !defined(WIN32)
+#include <sys/stat.h>
----------------
Also, this is no good. It works if you are targeting windows on windows, but not if you are targeting something else and building on windows. There are a few different ways this is done in LLVM/clang and they are generally not based on defined(WIN32). Here are a couple of examples:

>From llvm\lib\Support\Path.cpp:

```
#if !defined(_MSC_VER) && !defined(__MINGW32__)
```

>From clang\lib\Driver\Driver.cpp:

```
#if LLVM_ON_UNIX
```

>From llvm\lib\Support\ErrorHandling.cpp:

```
#if defined(HAVE_UNISTD_H)
```

I suggest browsing through the code and finding the most appropriate way to manage your includes. In the mean time, this is breaking our internal builds that run on Windows but do not target Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93951/new/

https://reviews.llvm.org/D93951