[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I am seeing this consistently fail on our internal Ubuntu bot:

  ERROR: test_missingArgInRunInTerminalLauncher (TestVSCode_runInTerminal.TestVSCode_runInTerminal)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/mnt/_work/5/s/lldb/packages/Python/lldbsuite/test/decorators.py", line 135, in wrapper
      return func(*args, **kwargs)
    File "/mnt/_work/5/s/lldb/test/API/tools/lldb-vscode/runInTerminal/TestVSCode_runInTerminal.py", line 92, in test_missingArgInRunInTerminalLauncher
      capture_output=True, universal_newlines=True)
    File "/usr/lib/python3.6/subprocess.py", line 423, in run
      with Popen(*popenargs, **kwargs) as process:
  TypeError: __init__() got an unexpected keyword argument 'capture_output'
  Config=x86_64-/mnt/_work/5/b/llvm/bin/clang
  ======================================================================
  FAIL: test_runInTerminal (TestVSCode_runInTerminal.TestVSCode_runInTerminal)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/mnt/_work/5/s/lldb/packages/Python/lldbsuite/test/decorators.py", line 135, in wrapper
      return func(*args, **kwargs)
    File "/mnt/_work/5/s/lldb/test/API/tools/lldb-vscode/runInTerminal/TestVSCode_runInTerminal.py", line 54, in test_runInTerminal
      env=["FOO=bar"])
    File "/mnt/_work/5/s/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py", line 353, in build_and_launch
      terminateCommands, sourcePath, debuggerRoot, runInTerminal=runInTerminal)
    File "/mnt/_work/5/s/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py", line 329, in launch
      'launch failed (%s)' % (response['message']))
  AssertionError: False is not True : launch failed (Failed to attach to the target process. Timed out trying to get messages from the runInTerminal launcher)
  Config=x86_64-/mnt/_work/5/b/llvm/bin/clang
  ----------------------------------------------------------------------
  Ran 7 tests in 2.447s
  
  RESULT: FAILED (5 passes, 1 failures, 1 errors, 0 skipped, 0 expected failures, 0 unexpected successes)
  Timed out trying to get messages from the debug adaptor


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93951/new/

https://reviews.llvm.org/D93951