[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 25 08:33:31 PST 2021


stella.stamenova added inline comments.


================
Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:87
   set(LLDB_LIBS_DIR_CONFIGURED "${LLDB_LIBS_DIR}")
+  set(LLVM_TOOLS_DIR_CONFIGURED "${LLVM_TOOLS_DIR_CONFIGURED}")
 
----------------
labath wrote:
> stella.stamenova wrote:
> > I think here you just want to set it to LLVM_TOOLS_BINARY_DIR, right?
> Yes, oops. Thanks for catching that.
You also need to add a line for LLDB_TEST_DSYMUTIL_CONFIGURED now that it is back


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95261/new/

https://reviews.llvm.org/D95261



More information about the lldb-commits mailing list