[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The fact that the test suite passes is not too surprising since we have very few core file tests. However, I agree that we should just remove this zero filling completely.

Regarding the test, would it be possible to reuse one of the existing core files? (The reason we have so few core tests is because we used to not allow checked in core files at all -- now we kinda do, but it's still not ideal.) I'm guessing you don't even need to disassemble a function to reproduce this -- it should be sufficient to run `disassemble --start-address X --end-address Y`, where the region `X--Y` crosses a core segment boundary..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93939/new/

https://reviews.llvm.org/D93939