[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

Wed Jan 20 14:33:31 PST 2021

clayborg added a comment.

In D94997#2509175 <https://reviews.llvm.org/D94997#2509175>, @tatyana-krasnukha wrote:

> D92164 <https://reviews.llvm.org/D92164> was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as soon as possible.

This settings set issue is not related to your diff, it is just because a target is created, the auto created target gets the settings set on it, and any new target created by "launchCommands" or "attachCommands" would not due to the way settings work in general.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94997/new/

https://reviews.llvm.org/D94997