[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

[Pedro Tammela via Phabricator via lldb-commits]

tammela added a comment.

In D94937#2505676 <https://reviews.llvm.org/D94937#2505676>, @JDevlieghere wrote:

> We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick?

If overloaded with `const char *GetStringValue(const char *fail_value = nullptr)`, SWIG emits a warning when building the Python wrapper saying that the method is shadowed and doesn't emit it.
`const char *GetStringValue()` works, however it doesn't follow the API contract.
Would adding a new method `GetConstStringValue()` also be acceptable?

I'm out of ideas to solve this. This method is very Python oriented, as the SWIG wrapper understands the {in,out} documentation. This doesn't happen for the Lua wrapper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94937/new/

https://reviews.llvm.org/D94937