[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Looks like a nice cleanup. The only part I am not sure of is the part about removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary?
I'm not sure why is that line there, but if I had to guess, I would say it's to ensure that lldb (on macos) reads debug info from the archive file instead of the original .o files. If it's not required, it may be better to leave it in. Otherwise, someone from Apple should say whether that is ok (testing archives is only really interesting on fruity platforms).

BTW, have you measured any speedups from these improvements?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94890/new/

https://reviews.llvm.org/D94890