[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 18 08:09:57 PST 2021


DavidSpickett added a comment.
Herald added a subscriber: JDevlieghere.

UBSAN might have caught this if we had a test that took this path but I need to confirm that. If so I could add some more as a smoke test of sorts, or just call help on every command if that's not going to take an age.

See `lldb/source/Interpreter/OptionGroupOutputFile.cpp` and `lldb/source/Commands/CommandObjectTarget.cpp` for two uses of these arbitrary short_option values. The calls to islower/upper are in `lldb/source/Interpreter/Options.cpp` `Options::GenerateOptionUsage`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94917/new/

https://reviews.llvm.org/D94917



More information about the lldb-commits mailing list