[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.
----------------
labath wrote:
> I don't know if this namespace snuck into the FreeBSD file, but generally, this is not the proper use of anonymous namespaces in llvm. See [[ http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding standards ]] for more details.
I guess I've copied it from Linux. Should I eliminate it entirely or move to `lldb_private::process_netbsd`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93541/new/

https://reviews.llvm.org/D93541