[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Dec 20 01:16:50 PST 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.
----------------
I don't know if this namespace snuck into the FreeBSD file, but generally, this is not the proper use of anonymous namespaces in llvm. See [[ http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding standards ]] for more details.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93541/new/

https://reviews.llvm.org/D93541



More information about the lldb-commits mailing list