[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 18 17:58:04 PST 2020

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

LGTM.  It looks like we never made use of the distinction between "started to finalize" and "done finalizing", so just marking it at the start of finalization seems fine.

I  quibble a bit with "m_finalized" because when it gets set to true we really are starting to finalize, we aren't done finalizing.  And it's a little weird to have tests for "am I shutting down", if so don't do X.  You might wonder, if we're really all the way done, who would ever ask me this question?  I think m_finalizing is a more accurate name.  But I don't feel strongly about this.

Comment at: lldb/source/Target/Process.cpp:1569
     // Use our target to get a shared pointer to ourselves...
+    m_private_state_broadcaster.BroadcastEvent(event_sp);
I don't think that comment refers to anything still in the code...  Might as well ax it here.



More information about the lldb-commits mailing list