[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 17 11:35:52 PST 2020


JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, vsk.
Herald added a subscriber: jfb.
JDevlieghere requested review of this revision.

This is a speculative fix when looking at the finalization code in Process. It tackles the following issues:

- Adds synchronization to prevent races between threads.
- Marks the process as finalized/invalid as soon as `Finalize` is called rather than at the end.
- Simplifies the code by using only a single instance variable to track finalization.


https://reviews.llvm.org/D93479

Files:
  lldb/include/lldb/Target/Process.h
  lldb/source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93479.312569.patch
Type: text/x-patch
Size: 5151 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201217/cb4b51c1/attachment.bin>


More information about the lldb-commits mailing list