[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

Mon Dec 7 01:50:25 PST 2020

mgorny added a comment.

In D92264#2436440 <https://reviews.llvm.org/D92264#2436440>, @labath wrote:

> I am having second thoughts about the image list approach to testing this. The regex matching is somewhat messy.
>
> A bad load address should manifest itself in plenty of other ways.. Could we print the value of some global variable to check that we got the correct one?

I suppose we could do that.

================
Comment at: lldb/test/API/commands/process/attach/TestProcessAttach.py:94
+
+        self.runCmd("process attach -p " + str(popen.pid))
+
----------------
labath wrote:
> Do you need to attach at any particular moment during the process startup? The attach command could run pretty quickly, before the loader finished its work...
I don't know ;-). Do you have any particular suggestion? That said, I suppose this means other tests suffer from the same problem, in particular they could attach before `lldb_enable_attach()`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92264/new/

https://reviews.llvm.org/D92264